Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of backporting Buffer fix to 5.x #216

Closed
LinusU opened this issue Oct 14, 2021 · 3 comments
Closed

Possibility of backporting Buffer fix to 5.x #216

LinusU opened this issue Oct 14, 2021 · 3 comments

Comments

@LinusU
Copy link

LinusU commented Oct 14, 2021

Hey,

We are currently using version 5.x of this library in node-fetch 2.x, which still support older versions of Node.js. There is a lot of users that are still on 2.x for us, so we still maintain and try to fix things there. A recent backport from our 3.x to 2.x started triggering deprecation warnings from this library. ref: node-fetch/node-fetch#1291 (comment)

Would you be open to a releasing a 5.0.1 version which just avoids the deprecation warnings?

If you could create a 5.x branch from d34854a, I would be happy to submit a pull request to that branch!

Thanks!

@domenic
Copy link
Member

domenic commented Oct 14, 2021

No, sorry, we only have the bandwidth to maintain a single version. You're welcome to fork the project and maintain your own separate fix.

@domenic domenic closed this as completed Oct 14, 2021
@LinusU
Copy link
Author

LinusU commented Oct 14, 2021

Understandable 👍

To be clear though, I'm not asking you to maintain anything, just publish the version. But I understand if you don't want that...

@domenic
Copy link
Member

domenic commented Oct 14, 2021

By "maintain" I mean "review and merge PRs, and do the publication work".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants