Add support for AbortSignal in addEventListener#3347
Merged
domenic merged 1 commit intojsdom:masterfrom Jun 19, 2022
cheap-glitch:addeventlistener-signal-option
Merged
Add support for AbortSignal in addEventListener#3347domenic merged 1 commit intojsdom:masterfrom cheap-glitch:addeventlistener-signal-option
domenic merged 1 commit intojsdom:masterfrom
cheap-glitch:addeventlistener-signal-option
Conversation
cheap-glitch
commented
Mar 20, 2022
This comment was marked as resolved.
This comment was marked as resolved.
|
@domenic is there anything else to do here? |
Member
|
No, I just haven't had time to review on recent weekends, and this is stuck behind other higher-priority items such as fixing jsdom on Node v18 where it is currently totally broken (see #3358). |
domenic
approved these changes
Jun 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3327