Upgrade parse5 to 3.0.2#1849
Merged
domenic merged 1 commit intojsdom:masterfrom May 14, 2017
Merged
Conversation
Member
|
Great stuff!! I guess this will have to be a major version bump because of the change to nodeLocation... Maybe we should also take the opportunity to remove the parser option, as we've been meaning to for a while. |
Contributor
|
We could patch |
Member
|
Nah, let's just release 11.0.0; version numbers are cheap. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades parse5 to version 3.0.2, and includes changes to affected tests and documentation. Since the ambitious changes in #1316 have not seen progress for a while, I figured that it'd be better to do this with minimal changes than to remain on such an old version.
I removed three old tests in the misc.js file which were testing the serialization of obsolete DOCTYPEs. From what I've gathered, parse5 removed support for these as they are no longer recognised in the spec.
In addition to the parser changes that have been made, there are also breaking changes to the API's output of
.nodeLocation. I've updated the tests and documentation to reflect this.This should resolve #1778 and any other issues which have been due to the old version 🎉