Set EventTarget.prototype to the jsdom's Object.prototype

domenic · domenic · commit 784c8a568937 · 2024-08-25T06:48:15.000-04:00
Previously it was set to the Node.js outer realm's Object.prototype.
diff --git a/lib/jsdom/browser/Window.js b/lib/jsdom/browser/Window.js
@@ -172,9 +172,7 @@ exports.createWindow = options => {
   Object.setPrototypeOf(window, windowPrototype);
   if (makeVMContext) {
     Object.setPrototypeOf(window._globalProxy, windowPrototype);
-
-    // TODO next major version: include this.
-    // Object.setPrototypeOf(window.EventTarget.prototype, window.Object.prototype);
+    Object.setPrototypeOf(window.EventTarget.prototype, window.Object.prototype);
   }
 
   // Now that the prototype chain is fully set up, call the superclass setup.
diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml
@@ -824,8 +824,6 @@ window-properties.https.html:
   "Window replaceable attribute: scrollX": [fail, Incorrectly implemented as a data property]
   "Window replaceable attribute: scrollY": [fail, Incorrectly implemented as a data property]
   "constructor": [fail-lt-node22, Incorrectly implemented VM global prototype properties]
-window-prototype-chain.html:
-  "Object.prototype": [fail, Tests Object.prototype which jsdom has trouble with due to VM globals]
 window-reuse-in-nested-browsing-contexts.tentative.html:
   "synchronously navigate iframe with no initial src.": [fail, Unknown]
   "after the first iframe load event, navigate iframe with no initial src.": [fail, Unknown]
