Skip to content

Commit 47ec321

Browse files
authored
Update dependencies and dev dependencies
Notably, the tough-cookie upgrade fixes the document-cookie.html web platform test, but also requires that we use proper non-about:blank URLs in our API tests.
1 parent 13b5840 commit 47ec321

File tree

5 files changed

+386
-250
lines changed

5 files changed

+386
-250
lines changed

package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@
2121
"repository": "jsdom/jsdom",
2222
"dependencies": {
2323
"abab": "^2.0.6",
24-
"acorn": "^8.7.1",
25-
"acorn-globals": "^6.0.0",
24+
"acorn": "^8.8.0",
25+
"acorn-globals": "^7.0.0",
2626
"cssom": "^0.5.0",
2727
"cssstyle": "^2.3.0",
2828
"data-urls": "^3.0.2",
29-
"decimal.js": "^10.3.1",
29+
"decimal.js": "^10.4.1",
3030
"domexception": "^4.0.0",
3131
"escodegen": "^2.0.0",
3232
"form-data": "^4.0.0",
@@ -35,16 +35,16 @@
3535
"https-proxy-agent": "^5.0.1",
3636
"is-potential-custom-element-name": "^1.0.1",
3737
"nwsapi": "^2.2.2",
38-
"parse5": "^7.0.0",
38+
"parse5": "^7.1.1",
3939
"saxes": "^6.0.0",
4040
"symbol-tree": "^3.2.4",
41-
"tough-cookie": "^4.0.0",
41+
"tough-cookie": "^4.1.2",
4242
"w3c-xmlserializer": "^3.0.0",
4343
"webidl-conversions": "^7.0.0",
4444
"whatwg-encoding": "^2.0.0",
4545
"whatwg-mimetype": "^3.0.0",
4646
"whatwg-url": "^11.0.0",
47-
"ws": "^8.8.0",
47+
"ws": "^8.9.0",
4848
"xml-name-validator": "^4.0.0"
4949
},
5050
"_dependenciesComments": {
@@ -63,11 +63,11 @@
6363
"benchmark": "^2.1.4",
6464
"browserify": "^17.0.0",
6565
"chai": "^4.3.6",
66-
"eslint": "^8.17.0",
67-
"eslint-plugin-html": "^6.2.0",
66+
"eslint": "^8.24.0",
67+
"eslint-plugin-html": "^7.1.0",
6868
"eslint-plugin-jsdom-internal": "link:./scripts/eslint-plugin",
6969
"js-yaml": "^4.1.0",
70-
"karma": "^6.3.20",
70+
"karma": "^6.4.1",
7171
"karma-browserify": "^8.1.0",
7272
"karma-chrome-launcher": "^3.1.1",
7373
"karma-mocha": "^2.0.1",
@@ -80,7 +80,7 @@
8080
"server-destroy": "^1.0.1",
8181
"watchify": "^4.0.0",
8282
"webidl2js": "^17.1.0",
83-
"yargs": "^17.5.1"
83+
"yargs": "^17.6.0"
8484
},
8585
"browser": {
8686
"canvas": false,

test/api/cookies.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ describe("Cookie processing", { skipIfBrowser: true }, () => {
143143
});
144144

145145
it("should not contain expired cookies (GH-1027)", () => {
146-
const { window } = new JSDOM();
146+
const { window } = new JSDOM(``, { url: testHost + "/TestPath/test-page" });
147147

148148
const timeNow = Date.now();
149149
const expiredDate = new Date(timeNow - 24 * 60 * 60 * 1000);

test/api/options.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ describe("API: constructor options", () => {
131131

132132
it("should reflect changes to the cookie jar in document.cookie", () => {
133133
const cookieJar = new jsdom.CookieJar();
134-
const { document } = (new JSDOM(``, { cookieJar })).window;
134+
const { document } = (new JSDOM(``, { url: "https://example.com/", cookieJar })).window;
135135

136136
cookieJar.setCookieSync("foo=bar", document.URL);
137137

@@ -140,15 +140,15 @@ describe("API: constructor options", () => {
140140

141141
it("should have loose behavior by default when using the CookieJar constructor", () => {
142142
const cookieJar = new jsdom.CookieJar();
143-
const { document } = (new JSDOM(``, { cookieJar })).window;
143+
const { document } = (new JSDOM(``, { url: "https://example.com/", cookieJar })).window;
144144

145145
cookieJar.setCookieSync("foo", document.URL);
146146

147147
assert.strictEqual(document.cookie, "foo");
148148
});
149149

150150
it("should have a loose-by-default cookie jar even if none is passed", () => {
151-
const dom = new JSDOM();
151+
const dom = new JSDOM(``, { url: "https://example.com/" });
152152
const { document } = dom.window;
153153

154154
dom.cookieJar.setCookieSync("foo", document.URL);

test/web-platform-tests/to-run.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -613,7 +613,6 @@ nameditem-names.html: [fail, Unknown]
613613

614614
DIR: html/dom/documents/resource-metadata-management
615615

616-
document-cookie.html: [fail, Unknown]
617616
document-lastModified-01.html: [fail, Unknown]
618617
document-lastModified.html: [fail, Unknown]
619618

0 commit comments

Comments
 (0)