Skip to content

Commit 2f8a730

Browse files
committed
Version 24.0.0
1 parent db0a4dc commit 2f8a730

5 files changed

Lines changed: 14 additions & 4 deletions

File tree

.mailmap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,4 @@ Christoph Pojer <[email protected]>
2525
Michał Gołębiowski-Owczarek <[email protected]>
2626
Jesus David Garcia Gomez <[email protected]> <[email protected]>
2727
Magne Andersson <[email protected]>
28+

AUTHORS.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ antonj <[email protected]>
3232
Aria Stewart <[email protected]>
3333
3434
Aryan Arora <[email protected]>
35-
asamuzaK (Kazz) <[email protected]>
3635
asamuzaK (Kazz) <[email protected]>
3736
Avery Fay <[email protected]>
3837
Avi Deitcher <[email protected]>

Changelog.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,16 @@ Other guidelines:
2626
* Roughly order changes within those groupings by impact.
2727
-->
2828

29+
## 24.0.0
30+
31+
This release reverts our selector engine back to [`nwsapi`](https://www.npmjs.com/nwsapi). As discussed in [#3659](https://github.com/jsdom/jsdom/issues/3659), the performance regressions from [`@asamuzakjp/dom-selector`](https://www.npmjs.com/package/@asamuzakjp/dom-selector) turned out to be higher than anticipated. In the future, we can revisit `@asamuzakjp/dom-selector` after it reaches `nwsapi`'s performance on the [two real-world benchmarks provided by the community](https://github.com/jsdom/jsdom/issues/3659#issuecomment-1890852609).
32+
33+
Since reverting to `nwsapi` causes several functionality regressions, e.g. removing `:has()` support, we've decided to make this a major version.
34+
35+
Additionally:
36+
37+
* Small fixes to edge-case behavior of the following properties: `input.maxLength`, `input.minLength`, `input.size`, `progress.max`, `tableCell.colSpan`, `tableCell.rowSpan`, `tableCol.span`, `textArea.cols`, `textArea.maxLength`, `textArea.minLength`, `textArea.rows`.
38+
2939
## 23.2.0
3040

3141
This release switches our CSS selector engine from [`nwsapi`](https://www.npmjs.com/nwsapi) to [`@asamuzakjp/dom-selector`](https://www.npmjs.com/package/@asamuzakjp/dom-selector). The new engine is more actively maintained, and supports many new selectors: see [the package's documentation](https://github.com/asamuzaK/domSelector#supported-css-selectors) for the full list. It also works better with shadow trees.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "jsdom",
3-
"version": "23.2.0",
3+
"version": "24.0.0",
44
"description": "A JavaScript implementation of many web standards",
55
"keywords": [
66
"dom",

0 commit comments

Comments
 (0)