This repository was archived by the owner on Jun 17, 2025. It is now read-only.
Conversation
Member
Kuniwak
commented
Feb 22, 2015
- Re-implement the parser with PEG
- Implement a publisher
- Implement a type builder for v1.2.0
- Restore removed legacy tests for v1.2.0
- Compatibility check for tj/dox
This was referenced Feb 22, 2015
Closed
added 11 commits
March 8, 2015 23:00
Closed
added 10 commits
April 26, 2015 12:42
I want to destinguish between strings and nodes by the a naming method: - "name:" mean that it is a name and the type is string - "value: mean that it is a representation value and the type is Node
Contributor
|
Tested just now:
|
added 8 commits
May 10, 2015 17:16
Member
Author
|
What remained for compatibility check for tj/dox. |
added 6 commits
May 11, 2015 00:24
Usage: bin/jsdoctypeparser 'Foo|Bar|Buz'
Member
Author
|
I tried the following code based on tj/dox example. /**
* Escape the given `html`.
*
* @example
* utils.escape('<script></script>')
* // => '<script></script>'
*
* @param {string[][]} html string to be escaped
* @return {{String}} escaped html
* @api public
*/
exports.escape = function(html){
return String(html)
.replace(/&(?!\w+;)/g, '&')
.replace(/</g, '<')
.replace(/>/g, '>');
}; |
Member
Author
|
@zxqfox Ready to be v1.2.0. |
Contributor
|
@Kuniwak trying... ;-) |
Contributor
|
@Kuniwak It works! Sorry for delay 🌴 |
Contributor
|
@Kuniwak Hm. I've found one trouble. What about multiline declarations? This one is parsed without syntax errors in current version: {rules: function(Object), configure: function(Object), cases: function(Array.<TestCase{it: string, code: Function, ?rules: Object, ?errors: *, ?skip: boolean}>), check: function(string)} |
Contributor
|
False error. All is fine. There is an error in syntax. 👍 NICE!!! Here are changes: https://github.com/jscs-dev/jscs-jsdoc/pull/105/files |
Member
Author
|
Thanks, @zxqfox ! |
qfox
pushed a commit
to jscs-dev/jscs-jsdoc
that referenced
this pull request
May 11, 2015
qfox
pushed a commit
to jscs-dev/jscs-jsdoc
that referenced
this pull request
May 11, 2015
jdlrobson
pushed a commit
to jdlrobson/jscs-jsdoc
that referenced
this pull request
Aug 21, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.