escape param/tag names before check#57
Closed
tunnckoCore wants to merge 1 commit intojscs-dev:masterfrom
tunnckoCore:feature/escape-param-names
Closed
escape param/tag names before check#57tunnckoCore wants to merge 1 commit intojscs-dev:masterfrom tunnckoCore:feature/escape-param-names
tunnckoCore wants to merge 1 commit intojscs-dev:masterfrom
tunnckoCore:feature/escape-param-names
Conversation
Member
|
I still think it should be optional. Like: {
"checkParamNames": "quircks"
}And it needs tests and readme update. And... I'm sure this shouldn't be valid ;-) /**
* @param {Number} `[n="u m"]` some description here
*/
function methodThree(num) {} |
Author
|
If we stick to this
it will add more complexity than simple regex. |
Member
|
@tunnckoCore Yeah, sure. But I'm almost did it. Thanks for interesting in this ;-) |
Author
Cool! |
jdlrobson
pushed a commit
to jdlrobson/jscs-jsdoc
that referenced
this pull request
Aug 21, 2015
Fixes: jscs-dev#56 Closes: jscs-dev#57 Closes: jscs-dev#58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
about #56 to allow