new rule: requireHyphenBeforeDescription#52
new rule: requireHyphenBeforeDescription#52qfox merged 2 commits intojscs-dev:masterfrom hzoo:require-hyphen-before-@param-description
Conversation
There was a problem hiding this comment.
Not sure about the location for the error.
There was a problem hiding this comment.
Seems like there are no location for description property ;-( Probably better to left here tag.loc for now.
There was a problem hiding this comment.
Doesn't look jscs has any way of testing the position of the error pointer right now? Since all of our tests in jscs and here are checking if error = 0 or 1.
There was a problem hiding this comment.
Can you check location? Something tells me that column should be passed as third parameter and easier to pass here .loc property
|
Nice work. ;-D |
|
Changed the wording for all the tests in |
|
Thanks! Merging? |
|
Yea sounds good. I wonder if jscs could let you check style for stuff like parameter names, and test case strings so it has the same format. |
|
Oh - I didn't change the readme yet - just remembered.. |
…tion new rule: requireHyphenBeforeDescription
|
Nice catch! I'll wait for README changes before publishing new version. Btw, jscs has deprecated rule |
|
Oh yeah I just meant whether it made sense to make a new rule to check for the correct naming like |
|
@hzoo Oh, probably |
2 participants
#50
This might need some more tests?
I'm assuming most people want the space so its like
- descriptionnot-descriptionso it works like
if (tag.description.substring(0, 2) !== '- ') {