Skip to content

Added @listens tag to jsdoc3.json#192

Merged
qfox merged 1 commit intojscs-dev:masterfrom
ianmcburnie:issue-191
Mar 16, 2016
Merged

Added @listens tag to jsdoc3.json#192
qfox merged 1 commit intojscs-dev:masterfrom
ianmcburnie:issue-191

Conversation

@ianmcburnie
Copy link
Copy Markdown
Contributor

@ianmcburnie ianmcburnie commented Feb 12, 2016

Fixes issue #191

@apsavin
Copy link
Copy Markdown

apsavin commented Mar 16, 2016

@zxqfox can we merge this?

@qfox
Copy link
Copy Markdown
Member

qfox commented Mar 16, 2016

Oh, sorry.

qfox added a commit that referenced this pull request Mar 16, 2016
@qfox
Merge pull request #192 from ianmcburnie/issue-191
5973c74 
Added @Listens tag to jsdoc3.json
@qfox qfox merged commit 5973c74 into jscs-dev:master Mar 16, 2016
@apsavin
Copy link
Copy Markdown

apsavin commented Mar 16, 2016

Thank you very much! Now you can close #191 and push a new version to npm)

@apsavin
Copy link
Copy Markdown

apsavin commented Mar 22, 2016

@zxqfox please-please-please, publish a version. Is there any reason not to do it?

2016-03-22 13 35 45

qfox pushed a commit that referenced this pull request Mar 22, 2016
@ianmcburnie @qfox
Tags: add listens to jsdoc3.json
f301aae 
Fixes #191
Closes gh-192
@qfox
Copy link
Copy Markdown
Member

qfox commented Mar 22, 2016

@apsavin Sorry, v1.3.2 published.

@apsavin
Copy link
Copy Markdown

apsavin commented Mar 22, 2016

Thank you so very much!;)

@qfox
Copy link
Copy Markdown
Member

qfox commented Mar 22, 2016

Btw, you don't need to wait for new tags. You can easily add them to your config via extra field:

{
  "checkAnnotations": {
    "preset": "jsdoc3",
    "extra": {
      "listens": true
    }
  }
}

@apsavin
Copy link
Copy Markdown

apsavin commented Mar 22, 2016

Sure. Thanks for the tip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianmcburnie @apsavin @qfox