requireDescriptionCompleteSentence: To detect and ignore HTML content#186
requireDescriptionCompleteSentence: To detect and ignore HTML content#186qfox merged 2 commits intojscs-dev:masterfrom
Conversation
This rule has been flagging comments with html tags. In this patch the html is sanitized with *** so that it doesn't interfere with the regular regex tests. The htmlSanitizer function is padding all strings with 'x.' so that RE_NEW_LINE_START_WITH_UPPER_CASE doesnt fail. This will need to be improved after discussing with owner if he/she thinks so. Fixes #2056
|
@zxqfox Let me know what you think? |
|
Looks good at all. Just need to fix nits. |
|
I am sorry for the errors ommission, I will rebase. |
|
@zxqfox, I wanted your review on the padding with of sanitized HTML with 'x.' |
|
Oh, don't worry! I'm usually forgetting to check codestyle when going to foreign repo. Guess it's a common problem. 😼 |
+1 to this solution as strong and simple. Another could be parsing, analyzing, etc. It's a kinda complex problem that needs additional research. |
Fixing omission of error statement and some further description Fixes #2056
|
@zxqfox Does it look good now? |
|
Yeah, lgtm. Ready to merge? |
|
Yes 👍 |
|
@zxqfox , friendly ping :) |
requireDescriptionCompleteSentence: To detect and ignore HTML content
This rule has been flagging comments with html tags. In this patch the html is sanitized with *** so that it doesn't interfere with the regular regex tests. The htmlSanitizer function is padding all strings with 'x.' so that RE_NEW_LINE_START_WITH_UPPER_CASE doesnt fail. This will need to be improved after discussing with owner if he/she thinks so. Fixes jscs-dev/node-jscs#2056 Closes gh-186
2 participants
This rule has been flagging comments with html tags.
In this patch the html is sanitized with *** so that it doesn't
interfere with the regular regex tests. The htmlSanitizer function
is padding all strings with 'x.' so that RE_NEW_LINE_START_WITH_UPPER_CASE
doesnt fail. This will need to be improved after discussing with owner if he/she
thinks so.
Fixes jscs-dev/node-jscs#2056