Bump comment-parser to v0.3.1#179
Bump comment-parser to v0.3.1#179ljharb wants to merge 1 commit intojscs-dev:masterfrom ljharb:patch-1
Conversation
(I'm not sure why this dep was pinned, this means all the downstreams will need to manually bump to get this fix. hopefully using a proper semver range is acceptable) [v0.3.1 of comment-parser](syavorsky/comment-parser#24 (comment)) uses the `readable-stream` module, which allows compatibility with node 0.8 and earlier. Whether you want to support node 0.8 isn't important - for your module, this change will function identically for > 0.8, and simply won't break for *this* reason on <= 0.8 - a net win!
Historical reasons of jscs guide. Thanks! Going to merge this. |
|
Thanks! When do you think a patch release could go out that includes this? |
|
@ljharb Feels like it's not enough for full support of Sorry for delay, releasing asap. |
|
@zxqfox Note how it's in After your publish, and the corresponding update in |
|
Yeah, right. That's pretty weird and still funny how it's going. I'll publish 1.3.0 in few hours. Thanks! |
2 participants
(I'm not sure why this dep was pinned, this means all the downstreams will need to manually bump to get this fix. hopefully using a proper semver range is acceptable)
v0.3.1 of comment-parser uses the
readable-streammodule, which allows compatibility with node 0.8 and earlier. Whether you want to support node 0.8 isn't important - for your module, this change will function identically for > 0.8, and simply won't break for this reason on <= 0.8 - a net win!