add new exclusion for enforce-existence - noParamsAndReturns#141
add new exclusion for enforce-existence - noParamsAndReturns#141webuniverseio wants to merge 1 commit intojscs-dev:masterfrom
Conversation
webuniverseio
force-pushed
the
feature/enforceExistence-no-params-and-returns
branch
4 times, most recently
from
767a727 to
91df507
Compare
There was a problem hiding this comment.
= Object.keys(this._enforceExistencePolicy) ?
There was a problem hiding this comment.
Sure, we can do that. In updatePolicyRules I'll change
policy[option] = false;to
policy[option] = !policy[option];There was a problem hiding this comment.
Also, please use 4 spaces as indent. Not sure why it wasn't reported by jscs. Bug?
There was a problem hiding this comment.
Sure, sorry about that. I use WebStorm EAP, looks like editor config settings are not picked up properly. Also jscs behaves funny. I think in .jscsrc we need to change "plugins": ["jscs-jsdoc"] to be "plugins": ["../jscs-jsdoc"]. That way both WebStorm integration and npm run lint work well. I'll try to update in this feature and see if build will pass.
There was a problem hiding this comment.
;-) Yeah, these IDE integration are pretty queasy on paths and global installation. In my case it's sublime on mac/win using samba/fuse to home directory on a linux server, and there's a lot of magics ;-D
Not sure that this fix will work well in all cases. "plugins" itself should resolve this imho.
webuniverseio
force-pushed
the
feature/enforceExistence-no-params-and-returns
branch
from
91df507 to
d0e2305
Compare
There was a problem hiding this comment.
Ah, in that way we can't call jscs itself. Just in npm run lint, right?
There was a problem hiding this comment.
We also can do something like node node_modules/jscs/bin/jscs test lib, but otherwise npm run lint is a way to do that.
webuniverseio
force-pushed
the
feature/enforceExistence-no-params-and-returns
branch
from
d0e2305 to
5472cd5
Compare
|
LGTM! Thanks for you hard work here ;-) |
|
:D Thank you too. I just used what was already in codebase. |
|
@zxqfox, will it be merged at some point later:question: :) |
|
Oh, 🍒 pick? |
2 participants
add new exclusion for enforce-existence - paramless-procedures, address #139