Skip to content

Breaking out the enforceExistence check into configurable sections#126

Closed
mattvot wants to merge 2 commits intojscs-dev:masterfrom
calvium:master
Closed

Breaking out the enforceExistence check into configurable sections#126
mattvot wants to merge 2 commits intojscs-dev:masterfrom
calvium:master

Conversation

@mattvot
Copy link
Copy Markdown
Contributor

@mattvot mattvot commented Jul 20, 2015

Can now specify checking documentation existence for:

  • All functions
  • Anonymous functions
  • Expression functions
  • Exports functions

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use this here with _ prefix for policy because there will be a conflict if somebody will use 2 different configurations at a time.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zxqfox How do you access this._policy from enforceExistence when it is defined as a property of enforceExistence.configure?

When using this._policy for both enforceExistence and enforceExistence.configure it fails tests.

@mattvot
Copy link
Copy Markdown
Contributor Author

mattvot commented Jul 24, 2015

Please, use this here with _ prefix for policy because there will be a conflict if somebody will use 2 different configurations at a time.

How do you access this._policy from enforceExistence when it is defined as a property of enforceExistence.configure?

When using this._policy for both enforceExistence and enforceExistence.configure it fails tests.

Maybe I'm misunderstanding the request, please help :)

@qfox
Copy link
Copy Markdown
Member

qfox commented Aug 2, 2015

@mattvot Sorry for a big delay. There were a bug in configuring validators, since now I've fixed that and the current master calls configure with the rule context (as well as validating function itself).

I hope you'll be fine if I finish this rule to push a release ;-)

@qfox qfox closed this in 140dfd6 Aug 2, 2015
jdlrobson pushed a commit to jdlrobson/jscs-jsdoc that referenced this pull request Aug 21, 2015
…ressions, etc.

- Refactored configuration and added options to suppress module.export and expression function definitions
- Added further tests and reconfigured configuration parsing

Fixes jscs-dev#110
Closes jscs-devgh-126
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants