fixup bug with constructor key in validators

Alexej Yaroshevich · Alexej Yaroshevich · commit 51d5cbb5eb3f · 2014-11-11T08:32:33.000+04:00
diff --git a/lib/rules/validate-jsdoc.js b/lib/rules/validate-jsdoc.js
@@ -41,8 +41,9 @@ module.exports.prototype = {
                 assert(v.length === 3, 'jsDoc rules: Wrong arity in ' + v._name + ' validator');
                 rulesForTags[scope] = rulesForTags[scope] || {};
                 v.tags.forEach(function(tag) {
-                    rulesForTags[scope][tag] = rulesForTags[scope][tag] || [];
-                    rulesForTags[scope][tag].push(v);
+                    var dtag = '@' + tag;
+                    rulesForTags[scope][dtag] = rulesForTags[scope][dtag] || [];
+                    rulesForTags[scope][dtag].push(v);
                 });
             });
         }, this);
@@ -104,12 +105,12 @@ module.exports.prototype = {
 
                 // call rule checkers
                 node.jsdoc.iterate(function(tag, i) {
-                    if (!validators[tag.id]) {
+                    if (!validators['@' + tag.id]) {
                         return;
                     }
                     // call tag validator
                     commentStart.line = commentStartLine + i;
-                    validators[tag.id].forEach(function(v) {
+                    validators['@' + tag.id].forEach(function(v) {
                         v.call(_this, node, tag, fixErrLocation(addError, tag));
                     });
                 });
diff --git a/test/lib/rules/validate-jsdoc.js b/test/lib/rules/validate-jsdoc.js
@@ -1,6 +1,6 @@
 var assert = require('assert');
 
-describe('rules/validate-jsdoc', function () {
+describe('lib/rules/validate-jsdoc', function () {
     var checker = global.checker({
         additionalRules: ['lib/rules/validate-jsdoc.js']
     });
@@ -32,4 +32,30 @@ describe('rules/validate-jsdoc', function () {
         });
 
     });
+
+    describe('additional checks', function () {
+
+        checker.cases([
+            /* jshint ignore:start */
+            {
+                it: 'should not throw anyway',
+                rules: {checkReturnTypes: true},
+                code: function() {
+                    /**
+                     * Cacher object
+                     * @constructor
+                     * @param {Object} o
+                     * @param {Object} [o.storage={}] initial storage for cache
+                     * @param {Number} [o.expTime=300] expiration time in seconds. 5 min by default
+                     */
+                    function Cacher (o) {
+                        // doesn't mean
+                    }
+                }
+            }
+            /* jshint ignore:end */
+        ]);
+
+    });
+
 });
