Fix type parsing bug

Alexej Yaroshevich · Alexej Yaroshevich · commit 136e2bebd06b · 2014-10-29T16:41:27.000+04:00
Merge branch 'hotfix/issue-16' Fixes #16
diff --git a/lib/jsdoc-helpers.js b/lib/jsdoc-helpers.js
@@ -218,8 +218,24 @@ function jsDocMatchType (variants, argument) {
         } else if (argument.type === 'ArrayExpression') {
             result = result || (type === 'array');
 
+        } else if (argument.type === 'NewExpression' && type === 'object') {
+            result = result || true;
+
         } else if (argument.type === 'NewExpression') {
-            result = result || ((type === 'object') || (type === argument.callee.name.toLowerCase()));
+            var c = argument.callee;
+            var exam = c.name;
+            if (!exam && c.type === 'MemberExpression') {
+                var cur = c;
+                exam = [];
+                while (cur.object) {
+                    exam.unshift(cur.property.name);
+                    cur = cur.object;
+                }
+                exam.unshift(cur.name);
+                exam = exam.join('.');
+            }
+            exam = exam.toLowerCase();
+            result = result || (type === exam);
         }
 
         if (result) {
diff --git a/test/test.validate-jsdoc-returns.js b/test/test.validate-jsdoc-returns.js
@@ -348,6 +348,37 @@ describe('rules/validate-jsdoc @returns', function() {
             );
         });
 
+        it('should not report on `@returns {foo.Bar}`. issue #16', function() {
+            checker.configure({ jsDoc: { requireReturnTypes: true, checkReturnTypes: true } });
+            assert(
+                checker.checkString(
+                    'module.exports = {\n' +
+                    '    /**\n' +
+                    '     * @return {foo.Bar}\n' +
+                    '     */\n' +
+                    '    foo: function () {\n' +
+                    '        return new foo.Bar();\n' +
+                    '    },\n' +
+                    '    /**\n' +
+                    '     * @return {foo.Bar.Baz}\n' +
+                    '     */\n' +
+                    '    bar: function () {\n' +
+                    '        return new foo.Bar.Baz();\n' +
+                    '    },\n' +
+                    '    /**\n' +
+                    '     * @return {foo.Bar.Baz|foo.Bar.Baz.Moo}\n' +
+                    '     */\n' +
+                    '    baz: function (t) {\n' +
+                    '        if (t) {\n' +
+                    '            return new foo.Bar.Baz.Moo();\n' +
+                    '        }\n' +
+                    '        return new foo.Bar.Baz();\n' +
+                    '    }\n' +
+                    '};\n'
+                ).isEmpty()
+            );
+        });
+
     });
 
 });
