Normative: Reject relativeTo string such as "2022-08-18T17:01Z"

ptomato · justingrant · commit 4db15c41bde8 · 2023-04-14T22:40:53.000-07:00
`relativeTo` strings must be either valid as PlainDate strings or as
ZonedDateTime strings. A string with a Z but no bracketed time zone
annotation is neither.

We probably missed this when forbidding Z designators for Plain types, so
it was an oversight.

UPSTREAM_COMMIT=2dc20bf69065c17631347f8b7e48cae651ae8a38
diff --git a/lib/ecmascript.ts b/lib/ecmascript.ts
@@ -1134,6 +1134,10 @@ export function ToRelativeTemporalObject(options: {
         offsetBehaviour = 'wall';
       }
       matchMinutes = true;
+    } else if (z) {
+      throw new RangeError(
+        'Z designator not supported for PlainDate relativeTo; either remove the Z or add a bracketed time zone'
+      );
     }
     if (!calendar) calendar = GetISO8601Calendar();
     calendar = ToTemporalCalendar(calendar);
diff --git a/test/expected-failures-todo-migrated-code.txt b/test/expected-failures-todo-migrated-code.txt
@@ -153,28 +153,24 @@ built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-calendar-fields
 built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-calendar-wrong-type.js
 built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-timezone-instance-does-not-get-timeZone-property.js
 built-ins/Temporal/Duration/prototype/add/relativeto-propertybag-timezone-wrong-type.js
-built-ins/Temporal/Duration/prototype/add/relativeto-string-datetime.js
 built-ins/Temporal/Duration/prototype/round/nanoseconds-to-days-loop-indefinitely-2.js
 built-ins/Temporal/Duration/prototype/round/order-of-operations.js
 built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-calendar-fields-undefined.js
 built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-calendar-wrong-type.js
 built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-timezone-instance-does-not-get-timeZone-property.js
 built-ins/Temporal/Duration/prototype/round/relativeto-propertybag-timezone-wrong-type.js
-built-ins/Temporal/Duration/prototype/round/relativeto-string-datetime.js
 built-ins/Temporal/Duration/prototype/subtract/order-of-operations.js
 built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-calendar-fields-undefined.js
 built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-calendar-wrong-type.js
 built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-timezone-instance-does-not-get-timeZone-property.js
 built-ins/Temporal/Duration/prototype/subtract/relativeto-propertybag-timezone-wrong-type.js
-built-ins/Temporal/Duration/prototype/subtract/relativeto-string-datetime.js
 built-ins/Temporal/Duration/prototype/toString/fractionalseconddigits-non-integer.js
 built-ins/Temporal/Duration/prototype/toString/order-of-operations.js
 built-ins/Temporal/Duration/prototype/total/order-of-operations.js
 built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-fields-undefined.js
 built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-calendar-wrong-type.js
 built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-instance-does-not-get-timeZone-property.js
 built-ins/Temporal/Duration/prototype/total/relativeto-propertybag-timezone-wrong-type.js
-built-ins/Temporal/Duration/prototype/total/relativeto-string-datetime.js
 built-ins/Temporal/Instant/compare/argument-string-calendar-annotation.js
 built-ins/Temporal/Instant/compare/argument-string-date-with-utc-offset.js
 built-ins/Temporal/Instant/compare/argument-string-time-zone-annotation.js

Original file line number	Diff line number	Diff line change
`@@ -1134,6 +1134,10 @@ export function ToRelativeTemporalObject(options: {`
`1134`	`1134`	`offsetBehaviour = 'wall';`
`1135`	`1135`	`}`
`1136`	`1136`	`matchMinutes = true;`
	`1137`	`+ } else if (z) {`
	`1138`	`+ throw new RangeError(`
	`1139`	`+ 'Z designator not supported for PlainDate relativeTo; either remove the Z or add a bracketed time zone'`
	`1140`	`+ );`
`1137`	`1141`	`}`
`1138`	`1142`	`if (!calendar) calendar = GetISO8601Calendar();`
`1139`	`1143`	`calendar = ToTemporalCalendar(calendar);`