Fix recursive set marshal dump and load#9418
Merged
Merged
Conversation
The overridden dump and load logic did not properly register the set object for recursive linking, causing it to become corrupted under those circumstances. This pulls the linking logic down from the base marshal implementation and ensures the set is registered before its contents are dumped or loaded. Fixes jruby#9405
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The overridden dump and load logic did not properly register the set object for recursive linking, causing it to become corrupted under those circumstances. This pulls the linking logic down from the base marshal implementation and ensures the set is registered before its contents are dumped or loaded.
Fixes #9405
No tests or specs are provided yet because the ruby/spec specs for Marshal dump and load are a mess. We'll get something added but first need some discussion about how to proceed (ruby/spec#1355).