Small marshal fixes#9156
Merged
Merged
Conversation
headius
force-pushed
the
marshal_fixes
branch
2 times, most recently
from
January 6, 2026 09:10
d3912e0 to
134c0d8
Compare
The previous logic checked if the link was present, and if so it proceeded to look it up again to get the link value. This saves a hash lookup per linked object in the dump stream.
All callers of this method are already linkable objects (i.e. not nil, boolean, or in CRuby fixnum range) so there's no need for the repeated checks in registerLinkTarget. The new registerObject retains those checks as an assert but otherwise assumes caller is doing the right thing.
headius
marked this pull request as ready for review
January 7, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small fixes for Marshal logic encountered while investigating #9152.