refactorings and cleanup motivated by error-prone#9141
Merged
Conversation
error: [ComparisonOutOfRange] ints may have a value in the range -2147483648 to 2147483647; therefore, this comparison to 0x7fffffff will always evaluate to true
[ComparisonOutOfRange] ints may have a value in the range -2147483648 to 2147483647; therefore, this comparison to BIGLEN_LIMIT will always evaluate to false
LexingCommon.java:[1491,79] error: [ComparisonOutOfRange] chars may have a value in the range 0 to 65535; therefore, this comparison to 0x10ffff will always evaluate to false
kares
changed the title
headius
approved these changes
Dec 30, 2025
headius
left a comment
headius
left a comment
Member
There was a problem hiding this comment.
Only minor things that may or may not need to be fixed. Seems like generally good changes to me.
| return 5; | ||
| } | ||
| if (code <= 0x7fffffff) { | ||
| //if (code <= 0x7fffffff) { // since 0x7fffffff == Integer.MAX_VALUE |
Member
There was a problem hiding this comment.
Does this change leave the code indented? If so that should be cleaned up.
| id: 'eclipse-hack', | ||
| phase: 'process-classes', | ||
| skipMain: 'true', | ||
| includes: ['**/*.java']) |
Member
There was a problem hiding this comment.
Unsure if this is sitll needed but I suppose we can remove it and see.
headius
added a commit
that referenced
this pull request
Dec 30, 2025
A final minor change after #9141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setting up
error_pronecompiler plugin (again), no longer ran on master (CI) since it was only activated on Java 11there's couple useful finds, handed them one by one in separate commits