Copy Data type's var table manager with new realClass #9138
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow Data types to specialize their fields completely, we introduced a copy constructor for VariableTableManager that duplicates the Data type's VTM into the new subclass. But because that duplicate still used the same realClass, variable accessors would frequently return to the original Data type's VTM rather than use the duplicate. This patch fixes the duplication process to also reset the realClass to the new Data type subclass, keeping all future usages and updates at the correct level. Without this, new instance variables discovered on subtypes would add an accessor on the subtype, but then proceed to allocate the variable table based on the size of the table in the old VTM from the Data supertype.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow Data types to specialize their fields completely, we introduced a copy constructor for VariableTableManager that duplicates the Data type's VTM into the new subclass. But because that duplicate still used the same realClass, variable accessors would frequently return to the original Data type's VTM rather than use the duplicate.
This patch fixes the duplication process to also reset the realClass to the new Data type subclass, keeping all future usages and updates at the correct level. Without this, new instance variables discovered on subtypes would add an accessor on the subtype, but then proceed to allocate the variable table based on the size of the table in the old VTM from the Data supertype.