Data fixes and improvements #8829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initialize from a subclass of a data class should properly locate the variable table associated with the data class. * Data should support zero-field definitions. The way we are locating the variable table is not right and will need to be reworked to support data subclasses with their own set of instance variables, but this gets tests running on net-imap that depended on these features. See ruby/net-imap#454
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
May 8, 2025
This should _not_ be merged into main. 😉 It's only temporary, until bugs in TruffleRuby and JRuby are addressed: * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
May 8, 2025
This should _not_ be merged into main. 😉 It's only temporary, until bugs in TruffleRuby and JRuby are addressed: * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
May 9, 2025
This should _not_ be merged into main. 😉 It's only temporary, until bugs in TruffleRuby and JRuby are addressed: * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
May 13, 2025
This should _not_ be merged into main. 😉 It's only temporary, until bugs in TruffleRuby and JRuby are addressed: * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
Member
|
Let's merge this? |
Member
Author
|
Yeah I'm done with this for now and did not run into other issues. I'll fix unrelated incompatibilities separately. |
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
Oct 22, 2025
These tests failed at some point on TruffleRuby or JRuby. We should mark them as pend_if_jruby or pend_if_truffleruby blocks, in order to detect when they are _fixed_ under those implementations. Some bugs related to this (which may have been fixed?): * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
Nov 29, 2025
These tests failed at some point on TruffleRuby or JRuby. We should mark them as pend_if_jruby or pend_if_truffleruby blocks, in order to detect when they are _fixed_ under those implementations. Some bugs related to this (which may have been fixed?): * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
nevans
added a commit
to ruby/net-imap
that referenced
this pull request
Dec 10, 2025
These tests failed at some point on TruffleRuby or JRuby. We should mark them as pend_if_jruby or pend_if_truffleruby blocks, in order to detect when they are _fixed_ under those implementations. Some bugs related to this (which may have been fixed?): * jruby/jruby#8829 * truffleruby/truffleruby#3846 * truffleruby/truffleruby#3847 The JRuby bug is a showstopper. The TruffleRuby bugs are cosmetic (inspect "nil" vs "") or academic (we never create recursive Data).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes here were driven by net-imap tests (ruby/net-imap#454) that depended on these features to even start up the library and tests. The fixes include:
There will need to be additional work to handle the variable table of data subclasses, rather than searching up the hierarchy, but this is enough to get the net-imap tests running.