correct/revisit exception backtrace (and stack-trace)#6014
Merged
kares merged 10 commits intojruby:masterfrom Jan 8, 2020
Merged
correct/revisit exception backtrace (and stack-trace)#6014kares merged 10 commits intojruby:masterfrom
kares merged 10 commits intojruby:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
original motivation for these changes was that the internal "lightweight" forced backtrace didn't have any reduced impact over a normal
raisebut also the fast that the legacy Java parts got neglected (not having the proper forced stack-trace as before).last part is probably due having two
TestRaiseExceptioncases - one of which wasn't run since the recent changes (adding the Java exception hierarchy for Ruby ones) ...than I realized
RaiseExceptionusually replaces a custom Java trace so not need to initiallyfillInStackTrace(which turned out to be potentially incorrectly on with-Xjump.backtrace)p.s. also added some minor pre-filtering (e.g.
getStackTracefrom top - has been bothering me for a while 🙈) - we could take it further to skip the Java stack trace head to not include all of the exception<init>(all the way tojava.lang.Throwable.<init>) ... maybe later.