-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Document the new signature of the CreateCustomForm() function
#573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the new signature of the CreateCustomForm() function
#573
Conversation
911edd7 (Resize before page initialization., 2025-10-23) changed the signature, but did not adjust the documentation. Signed-off-by: Johannes Schindelin <[email protected]>
|
Thanks Johannes! |
The signature of the `CreateCustomForm()` function changed. See also jrsoftware/issrc#573. Signed-off-by: Johannes Schindelin <[email protected]>
|
You're welcome! I had an idea: Do you think it would be possible to add defaults for those new parameters for backwards-compatibility (so that existing |
|
I’m not sure which script would benefit from that change, even if having such defaults were possible. Every script would need to set at least one of these values, right? Prior to version 6.6, this was accomplished by setting properties after calling CreateCustomForm. However, those properties are now read-only, since CreateCustomForm itself now requires these values up front. So even if there was a CreateCustomForm without arguments, the script would still break because it would try to set read-only properties. Are you suggesting that you think there were scripts which called CreateCustomForm without setting any of the four properties? Or perhaps that this was the case for your own script? |
Hmm. I had not thought about that. It's just a little sad that existing |
|
Yes, I agree and always aim to maintain backward compatibility whenever possible, but I did not see a good way to achieve that in this case. When you start using features like CreateCustomForm, you get closer to the internal workings. The change should be straightforward though. Should the help file explain more? |
Maybe an example could help, something like:
|
|
Thanks 👍 |
Of course! Any word when this will hit https://jrsoftware.org/ishelp/index.php?topic=isxfunc_createcustomform? |
|
I’ve updated it now. You might need to force refresh by holding Shift. |
Thank you! |
911edd7 (Resize before page initialization., 2025-10-23) changed the signature, but did not adjust the documentation.