Fix bug involving conflict between AttrJson::Model NestedAttributes and defaults - #160
Merged
Conversation
…nd defaults Ran into this bug in a real world case involving setting array default to empty array. It was very confusing and complicated, I found it too hard to reproduce the actual case in a spec, this simple spec was the best I could do for failing before the change passing after. Only apply defaults after initialiation, with args passed in initialization, only if defaults are still needed. Previously, defaults were sometimes accidentally over-writing values set with `*_attributes` keys, in real world use cases. This is a better way of doing defaults anyway... not sure what the comment saying that method couldn't be private was about, or why it was on class instead of instance. I think those were leftover from previous implementations, currently this is simpler anyhow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this bug in a real world case involving setting array default to empty array. It was very confusing and complicated, I found it too hard to reproduce the actual case in a spec, this simple spec was the best I could do for failing before the change passing after.
Only apply defaults after initialiation, with args passed in initialization, only if defaults are still needed. Previously, defaults were sometimes accidentally over-writing values set with
*_attributeskeys, in real world use cases..fill_in_defaultsclass method is removed -- it was never meant as public API anyhow.This is a better way of doing defaults anyway... not sure what the comment saying that method couldn't be private was about, or why it was on class instead of instance. I think those were leftover from previous implementations, currently this is simpler anyhow.