Build: Update tested browsers, test on Edge 15-18 instead of just 17-18 #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I run the full test suite locally on this branch & it passed so |
Member
Author
|
This PR shouldn't be controversial so I'll merge it soon if no one opposes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sizzle supports all versions of Edge (see https://github.com/jquery/sizzle/wiki#-browser-support), so 12+. We only tested v17 & v18 so far while BrowserStack makes all version starting from 15 available. We should test in them all as sometimes it catches a new issue (see #461 (comment)). Plus, new EdgeHTML-based versions of Edge are unlikely so this list won't get much bigger.