Selector: Make empty attribute selectors work in IE 11/Edge again #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Member
Author
|
+51 bytes |
Member
Author
|
It looks like the workaround makes Sizzle tests pass in IE 11 & Edge 16-18 but it still fails in Edge 15... I don’t think they’d change the behavior around it somehow & then back so I worry about stability of this workaround. |
Member
Author
|
I submitted #462 to update tested browsers but also add Edge 15 & 16 to the mix so that issues like the one described above are caught more often. |
mgol
force-pushed
the
attr-empty
branch
4 times, most recently
from
11f8395 to
4d71b18
Compare
Member
Author
|
PR updated. |
Member
Author
|
|
timmywil
approved these changes
Oct 21, 2019
timmywil
approved these changes
Oct 21, 2019
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Fixes jquery/jquery#4435
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 8, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 19, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 21, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 3, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 4, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 17, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 1, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 13, 2022
qSA in IE 11/Edge often (but not always) don't find elements with an empty name attribute selector (`[name=""]`). Detect that & fall back to Sizzle traversal. Interestingly, IE 10 & older don't seem to have the issue. Ref jquerygh-4435 Ref jquerygh-4510 Ref jquery/sizzle#461
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qSA in IE 11/Edge often (but not always) don't find elements with an empty
name attribute selector (
[name=""]).Assigning a temporary name attribute tothe document root (& removing it afterwards) seems to resolve the issue.
EDIT: Detect that & fall back to Sizzle traversal.
Interestingly, IE 10 & older don't seem to have the issue.
Fixes jquery/jquery#4435
jQuery version of the PR: jquery/jquery#4510