Selector: Use shallow document comparisons to avoid IE/Edge cras… #459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
approved these changes
Sep 30, 2019
gibson042
approved these changes
Sep 30, 2019
mgol
force-pushed
the
doc-shallow-compare
branch
from
2893b72 to
dd17d06
Compare
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Fixes jquery/jquery#4441 Closes jquery/jquery#4471
mgol
force-pushed
the
doc-shallow-compare
branch
from
dd17d06 to
72b0f99
Compare
mgol
changed the title
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 14, 2019
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in jquerygh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Those changes have landed in Sizzle in jquery/sizzle#459. Fixes jquerygh-4441 Closes jquerygh-4471 Ref jquery/sizzle#459
4 tasks
mgol
added a commit
to jquery/jquery
that referenced
this pull request
Oct 21, 2019
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. The change to shallow comparisons in `src/selector.js` was done in gh-4471 but relevant changes in `src/selector/uniqueSort.js` were missed. Those changes have landed in Sizzle in jquery/sizzle#459. Fixes gh-4441 Closes gh-4512 Ref gh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 8, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 12, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 19, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Sep 21, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 3, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Oct 4, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 17, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 1, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Dec 13, 2022
IE/Edge sometimes crash when comparing documents between frames using the strict equality operator (`===` & `!==`). Funnily enough, shallow comparisons (`==` & `!=`) work without crashing. Ref jquerygh-4441 Ref jquerygh-4471 Ref jquery/sizzle#459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a version of jquery/jquery#4471 for Sizzle which will be needed to fix it for jQuery 3.x (jQuery 4 doesn't use Sizzle anymore so the fix was in jQuery itself).
IE/Edge sometimes crash when comparing documents between frames using the strict
equality operator (
===&!==). Funnily enough, shallow comparisons(
==&!=) work without crashing.Fixes jquery/jquery#4441
Closes jquery/jquery#4471