Selector: Webkit broke sibling of filtered id selection #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -614,7 +614,7 @@ setDocument = Sizzle.setDocument = function( node ) { | |||
| // setting a boolean content attribute, | |||
| // since its presence should be enough | |||
| // http://bugs.jquery.com/ticket/12359 | |||
| div.innerHTML = "<select msallowcapture=''>" + | |||
| div.innerHTML = "<a id='" + expando + "'></a><select msallowcapture=''>" + | |||
There was a problem hiding this comment.
well, you could save 2 bytes by
docElem.appendChild( div ).innerHTML = ...but that's just not pretty and out of place
There was a problem hiding this comment.
I actually did try that, but couldn't get it to a net benefit after the necessary rearranging of id='d\f]', which is no longer guaranteed valid (i.e., unique) once we're in the document. However, I just gave it another shot and pulled it off; I'll push here after testing with iOS 8. Thanks!
gibson042
added a commit
that referenced
this pull request
Dec 12, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
Increases minified+gzipped size by 30 bytes... ridiculous. Does anyone see room for further improvement?