Spinner: Prevent double mousewheel & wheel event handling#2342
Merged
mgol merged 2 commits intojquery:mainfrom Mar 20, 2025
Merged
Spinner: Prevent double mousewheel & wheel event handling#2342mgol merged 2 commits intojquery:mainfrom
mgol merged 2 commits intojquery:mainfrom
Conversation
As of jquerygh-2338, if one has loaded the jQuery MouseWheel plugin, the `mousewheel` handler would fire the `wheel` one, but the `wheel` one would also run in response to the native `wheel` event, resulting in double the distance handled by the spinner. To prevent the issue, only fire the `wheel` handler from inside the `mousewheel` on if the event was triggered by jQuery - jQuery will not care that the underlying event is `wheel` and will only fire handlers for `mousewheel`. Also, add an iframe test using jQuery MouseWheel to not affect all the other tests. Ref jquerygh-2338
Also: * Migrate the new wheel + mousewheel spinner test to use it * Migrate from `QUnit.reset` to `QUnit.done` (see qunitjs/qunit#354)
mgol
force-pushed
the
mousewheel-wheel-interaction
branch
from
2144831 to
bedc762
Compare
melloware
approved these changes
Mar 19, 2025
fnagel
approved these changes
Mar 20, 2025
Member
fnagel
left a comment
fnagel
left a comment
There was a problem hiding this comment.
Make sense and looks good by reading!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of gh-2338, if one has loaded the jQuery MouseWheel plugin, the
mousewheelhandler would fire the
wheelone, but thewheelone would also run inresponse to the native
wheelevent, resulting in double the distance handledby the spinner. To prevent the issue, only fire the
wheelhandler from insidethe
mousewheelon if the event was triggered by jQuery - jQuery will not carethat the underlying event is
wheeland will only fire handlers formousewheel.Also, add an iframe test using jQuery MouseWheel to not affect all the other
tests.
Ref gh-2338