Skip to content

Commit 174bb27

Browse files
mgolmgol
authored
Apply suggestions from code review
1 parent 42edf77 commit 174bb27

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

‎tests/unit/dialog/core.js‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -91,31 +91,31 @@ QUnit.test( "aria-modal", function( assert ) {
9191
wrapper = element.dialog( "widget" );
9292
assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" );
9393
element.dialog( "option", "modal", false );
94-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" );
94+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" );
9595
element.dialog( "option", "modal", null );
96-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" );
96+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" );
9797
element.dialog( "option", "modal", true );
9898
assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" );
9999
element.remove();
100100

101101
var element = $( "<div>" ).dialog( { modal: false } ),
102102
wrapper = element.dialog( "widget" );
103-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" );
103+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" );
104104
element.dialog( "option", "modal", true );
105105
assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" );
106106
element.dialog( "option", "modal", null );
107-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" );
107+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" );
108108
element.dialog( "option", "modal", false );
109-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" );
109+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" );
110110
element.remove();
111111

112112
var element = $( "<div>" ).dialog(),
113113
wrapper = element.dialog( "widget" );
114-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option not set, aria-modal attribute not added" );
114+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option not set, aria-modal attribute not added" );
115115
element.dialog( "option", "modal", true );
116116
assert.equal( wrapper.attr( "aria-modal" ), "true", "modal option set to true, aria-modal attribute added" );
117117
element.dialog( "option", "modal", false );
118-
assert.ok( !wrapper.attr( "aria-modal" ), "modal option set to false, aria-modal attribute not added" );
118+
assert.equal( wrapper.attr( "aria-modal" ), undefined, "modal option set to false, aria-modal attribute not added" );
119119
element.dialog( "option", "modal", null );
120120
assert.equal( wrapper.attr( "aria-modal" ), null, "modal option not set, aria-modal attribute not added" );
121121
element.remove();

0 commit comments

Comments
 (0)