Build:util: await methods passed to Release.walk, test on Node 12 #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@timmywil I will need this for the Inquirer prompting to provide a jQuery blog post link. |
2 tasks
timmywil
approved these changes
Feb 24, 2020
… to 12 Changes: 1. Test on Node.js 12 instead of 10 2. Make `Release.walk` an async function, `await` each provided method. This makes it possible to easier integrate with asynchronous flows in various steps. 3. Throw on unhandled rejections, making jquery-release quit if any of the async steps passed to `Release.walk` ends up in a rejected state.
Member
Author
|
@timmywil I backported unhandled rejection handling here, can you have another look? The diff between what you reviewed and the current version: https://github.com/jquery/jquery-release/compare/632a6fc665ce6cd81d92e591108005cdcb00dcc6..25a1b9d206a91146b36be9747171140fd56ec256 |
arschmitz
approved these changes
Feb 28, 2020
Member
arschmitz
left a comment
arschmitz
left a comment
There was a problem hiding this comment.
This looks good to me much prefer async functions was going to ask for the error handling when i first looked this morning but looks like you added it so i'm good
timmywil
approved these changes
Mar 2, 2020
mgol
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Release.walkan async function,awaiteach provided method. Thismakes it possible to easier integrate with asynchronous flows in various steps.