Build: Restore the external directory #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
force-pushed
the
restore-external-directory
branch
from
59b1dba to
1e04847
Compare
In c12e1ab, we removed the `external` directory in favor of loading some files directly from `node_modules`. This works fine locally but when deploying code for tests, this makes it impossible to not deploy `node_modules` as well. To avoid the issue, this change restores usage of the `external` directory. One change is that we no longer commit this directory to the repository, its only purpose is to have clear isolation from `node_modules`. Ref jquery/jquery#4865
mgol
force-pushed
the
restore-external-directory
branch
from
1e04847 to
17f0afd
Compare
Member
Author
|
@dmethvin I merged relevant infra changes so until this lands, Migrate cannot be tested on TestSwarm. |
dmethvin
approved these changes
Mar 25, 2021
Member
dmethvin
left a comment
dmethvin
left a comment
There was a problem hiding this comment.
Looks good. Welcome back npmcopy! 😄
mgol
changed the title
external directory
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Mar 25, 2021
jquerygh-419 missed a few occurrences. It was overlooked as Chrome & Firefox didn't fail any tests because of the missing CSS but IE did, see: http://swarm.jquery.org/job/11000 Ref 419
Member
Author
|
It looks like I missed a few things; a followup is in #420. |
mgol
added a commit
that referenced
this pull request
Mar 26, 2021
gh-419 missed a few occurrences. It was overlooked as Chrome & Firefox didn't fail any tests because of the missing CSS but IE did, see: http://swarm.jquery.org/job/11000 Ref gh-419 Closess gh-420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In c12e1ab, we removed the
externaldirectoryin favor of loading some files directly from
node_modules. This works finelocally but when deploying code for tests, this makes it impossible to not
deploy
node_modulesas well. To avoid the issue, this change restores usageof the
externaldirectory.One change is that we no longer commit this directory to the repository, its
only purpose is to have clear isolation from
node_modules.Ref jquery/jquery#4865