Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented May 18, 2020

The previous replacement:

text == null ? "" : text.trim()

didn't account for non-null non-string input, e.g. numbers.

The previous replacement:
```js
text == null ? "" : text.trim()
```
didn't account for non-`null` non-string input, e.g. numbers.
@mgol mgol added this to the 3.3.1 milestone May 18, 2020
@mgol mgol requested a review from dmethvin May 18, 2020 21:17
@mgol mgol self-assigned this May 18, 2020
@mgol mgol merged commit a19eabe into master May 20, 2020
@mgol mgol deleted the mgol-trim-warnings-md branch May 20, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants