Skip to content

Commit 758a138

Browse files
committed
Effects: Don't warn about interval if document is hidden
Fixes #292
1 parent 856931d commit 758a138

File tree

1 file changed

+17
-3
lines changed

1 file changed

+17
-3
lines changed

src/effects.js

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,25 @@ jQuery.Tween.prototype.run = function( ) {
1515
oldTweenRun.apply( this, arguments );
1616
};
1717

18-
jQuery.fx.interval = jQuery.fx.interval || 13;
18+
var intervalValue = jQuery.fx.interval || 13,
19+
intervalMsg = "jQuery.fx.interval is deprecated";
1920

2021
// Support: IE9, Android <=4.4
2122
// Avoid false positives on browsers that lack rAF
23+
// Don't warn if document is hidden, jQuery uses setTimeout (#292)
2224
if ( window.requestAnimationFrame ) {
23-
migrateWarnProp( jQuery.fx, "interval", jQuery.fx.interval,
24-
"jQuery.fx.interval is deprecated" );
25+
Object.defineProperty( jQuery.fx, "interval", {
26+
configurable: true,
27+
enumerable: true,
28+
get: function() {
29+
if ( !window.document.hidden ) {
30+
migrateWarn( intervalMsg );
31+
}
32+
return intervalValue;
33+
},
34+
set: function( newValue ) {
35+
migrateWarn( intervalMsg );
36+
intervalValue = newValue;
37+
}
38+
} );
2539
}

0 commit comments

Comments
 (0)