No Ticket: jQuery in strict mode #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct" is added to the main jQuery closure and some "could-be-unsafe" `this` trickery in effects is silenced.
Member
Author
|
Also, the "use strict" directive has to stay in the minified file because it changes runtime behaviour. |
.jshintrc
Outdated
Member
There was a problem hiding this comment.
Unnecessary, as the node: true option covers this already.
Member
Author
There was a problem hiding this comment.
Good to know. On the move today, feel free to hack in the branch ;)
jaubourg
added a commit
that referenced
this pull request
Oct 19, 2012
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to see if anyone knew of any place in the code where we assume
thisto bewindowin functions called without a context before merging this in (that's the only change in behaviour I can think of but feel free to correct me, I'm not a strict mode specialist).Also, I didn't enforce strict mode for the test directory yet, seeing as everything single test function would require a "use strict" declaration or we'd need to embed every unit file into an IIFE (something that could probably be done automagically but my eyes burn and I need to sleep right now).