-
Notifications
You must be signed in to change notification settings - Fork 20.5k
[1.9] Fixes #12061 #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.9] Fixes #12061 #894
Conversation
|
I love the use of the |
|
In IE6 this will not work – but this will – In this test, i wanted to check if user function attached through window object will not clobber jQuery beforeunload event, but i can't do that in IE6. |
|
@Orkel, looks like a legit failure in Safari 5.0? I was able to reproduce on BrowserStack. Perhaps Safari 5.0 requires window.onbeforeunload? http://swarm.jquery.org/result/359338 |
|
If we can fix Safari 5.0, we probably should, but it's not on the supported browser list. We should really update TestSwarm. |
|
There must be some mobile devices on Safari 5.0 still? If not, great, Or if it's a small number we could document that this one thing doesn't work on them. |
|
Beforeunload event does not work on iframes in IE6 if event handler was defined through window object, but it will work, if this event was binded though attachEvent. In old Safari this event will not work on iframes regardless how it was binded, but it will work on parent window. So this test will fail with new or with old code in old Safari. How want to do this? I could replace this test on synthetic one or leave it be? |
|
Okay, so this only affects iframes, and only in Safari 5.0. We just need to avoid getting a unit test failure, can you do a patch for that? |
|
there you go – #1002 |
This was fixed a long time ago