Skip to content

Conversation

@markelog
Copy link
Member

This was fixed a long time ago

@dmethvin
Copy link
Member

I love the use of the postDispatch hook! How is this providing support for IE6 though?

@markelog
Copy link
Member Author

In IE6 this will not work –
[iframe doc].onbeforeunload = [ some function ]

but this will –
[iframe doc].attachEvent( "onbeforeunload", [ some function ] );

In this test, i wanted to check if user function attached through window object will not clobber jQuery beforeunload event, but i can't do that in IE6.

@dmethvin dmethvin closed this in 9dd0b01 Oct 21, 2012
@dmethvin
Copy link
Member

@Orkel, looks like a legit failure in Safari 5.0? I was able to reproduce on BrowserStack. Perhaps Safari 5.0 requires window.onbeforeunload? http://swarm.jquery.org/result/359338

@scottgonzalez
Copy link
Member

If we can fix Safari 5.0, we probably should, but it's not on the supported browser list. We should really update TestSwarm.

@dmethvin
Copy link
Member

There must be some mobile devices on Safari 5.0 still? If not, great, Or if it's a small number we could document that this one thing doesn't work on them.

@markelog
Copy link
Member Author

Beforeunload event does not work on iframes in IE6 if event handler was defined through window object, but it will work, if this event was binded though attachEvent.

In old Safari this event will not work on iframes regardless how it was binded, but it will work on parent window. So this test will fail with new or with old code in old Safari.

How want to do this? I could replace this test on synthetic one or leave it be?

@dmethvin
Copy link
Member

Okay, so this only affects iframes, and only in Safari 5.0. We just need to avoid getting a unit test failure, can you do a patch for that?

@markelog
Copy link
Member Author

there you go – #1002

mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants