Skip to content

Conversation

@mgol
Copy link
Member

@mgol mgol commented Dec 24, 2025

Summary

Example on the desktop in Element Classic:
Screenshot 2025-12-24 at 02 44 50

Example on iOS in Element X:
IMG_8966

Checklist

@mgol mgol requested a review from timmywil December 24, 2025 01:51
@mgol mgol self-assigned this Dec 24, 2025
@mgol
Copy link
Member Author

mgol commented Dec 24, 2025

We could add more details to these messages, but clicking on the link to look at the logs looks easy enough.

Comment on lines +190 to +191
MATRIX_PASSWORD: ${{ secrets.MATRIX_PASSWORD }}
MATRIX_ROOM_ID: ${{ secrets.MATRIX_ROOM_ID }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two additional secrets are needed in the new matrix-notifications environment.

BTW, GitHub doesn't allow to rename environments, so changing that later requires a few more steps than it should.

@mgol mgol mentioned this pull request Dec 24, 2025
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgol mgol force-pushed the browser-tests-beta-matrix-notification branch from 798d20a to 37f04a4 Compare January 5, 2026 23:34
@mgol
Copy link
Member Author

mgol commented Jan 6, 2026

I've added the matrix-notifications environment to jquery/jquery now.

@mgol mgol added Build and removed Needs review labels Jan 6, 2026
@mgol mgol merged commit afdd032 into jquery:main Jan 6, 2026
16 checks passed
@mgol mgol deleted the browser-tests-beta-matrix-notification branch January 6, 2026 23:48
mgol added a commit that referenced this pull request Jan 6, 2026
@mgol mgol added this to the 3.8.0 milestone Jan 6, 2026
@mgol
Copy link
Member Author

mgol commented Jan 6, 2026

Landed on main in afdd032 & on 3.x-stable in a69e173.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants