-
Notifications
You must be signed in to change notification settings - Fork 20.5k
Build: Post beta browser tests errors to jquery/dev on Matrix #5749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We could add more details to these messages, but clicking on the link to look at the logs looks easy enough. |
| MATRIX_PASSWORD: ${{ secrets.MATRIX_PASSWORD }} | ||
| MATRIX_ROOM_ID: ${{ secrets.MATRIX_ROOM_ID }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two additional secrets are needed in the new matrix-notifications environment.
BTW, GitHub doesn't allow to rename environments, so changing that later requires a few more steps than it should.
timmywil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending adding a link to matrix API docs
798d20a to
37f04a4
Compare
|
I've added the |
Summary
Example on the desktop in Element Classic:

Example on iOS in Element X:

Checklist
New tests have been added to show the fix or feature worksIf needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com