CSS: Fix dimensions of table <col> elements
#5634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: 1. Fix measurements of `<col span="2">` elements in Firefox. 2. Fix measurements of all implicitly sized `<col>` elements in Safari. Firefox always reports computed width as if `span` was 1. In Safari, computed width for columns is always 0. Work around both issues by using `offsetWidth`. In IE/Edge, `<col>` computed width is `"auto"` unless `width` is set explicitly via CSS so measurements there remain incorrect. Because of the lack of a proper workaround, we accept this limitation. Fixes jquerygh-5628
mgol
force-pushed
the
3.x-col-width-fixes
branch
from
91189bd to
67709ce
Compare
gibson042
approved these changes
Feb 24, 2025
timmywil
approved these changes
Feb 24, 2025
mgol
added a commit
that referenced
this pull request
Feb 24, 2025
Changes: 1. Fix measurements of `<col span="2">` elements in Firefox. 2. Fix measurements of all implicitly sized `<col>` elements in Safari. Firefox always reports computed width as if `span` was 1. In Safari, computed width for columns is always 0. Work around both issues by using `offsetWidth`. In IE/Edge, `<col>` computed width is `"auto"` unless `width` is set explicitly via CSS so measurements there remain incorrect. Because of the lack of a proper workaround, we accept this limitation. Fixes gh-5628 Closes gh-5630 Ref gh-5634
Member
Author
|
Size diff: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
3.x version of PR #5630.
In this one, we are keeping the style swap even for table col elements for compat reasons.Changes:
<col span="2">elements in Firefox.<col>elements in Safari.Firefox always reports computed width as if
spanwas 1. In Safari, computed width for columns is always 0. Work around both issues by usingoffsetWidth.In IE/Edge,
<col>computed width is"auto"unlesswidthis set explicitly via CSS so measurements there remain incorrect. Because of the lack of a proper workaround, we accept this limitation.Fixes gh-5628
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com