Tests: Backport the hidden="until-found" attr tests from 3.x-stable
#5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `hidden` attribute used to be a boolean one but it gained a new `until-found` eventually. This led us to change the way we handle boolean attributes in jQuery 4.0 in jquerygh-5452 to avoid these issues in the future. We haven't added an explicit test for the `"until-found"` value of the `hidden` attribute which triggered this decision so far, though. Backport the test from jquerygh-5607 which landed on `3.x-stable` so that we do test it. Ref jquerygh-5452 Ref jquerygh-5607 (cherry picked from commit 85290c5)
timmywil
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
hiddenattribute used to be a boolean one but it gained a newuntil-foundeventually. This led us to change the way we handle boolean attributes in jQuery 4.0 in gh-5452 to avoid these issues in the future.We haven't added an explicit test for the
"until-found"value of thehiddenattribute which triggered this decision so far, though. Backport the test from gh-5607 which landed on3.x-stableso that we do test it.Ref gh-5452
Ref gh-5607
(cherry picked from commit 85290c5)
Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com