Skip to content

Build: Stop testing on iOS 10 #5606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 2, 2025

Summary

As of January 2025, iOS 10 is a tier 4 device on BrowserStack: https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and failing our tests. Remove it from the test matrix. Also, add comments explaining the status of tests on various iOS versions, including iOS 7 that we stopped testing on a long time ago.

Checklist

As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and
failing our tests. Remove it from the test matrix. Also, add comments explaining
the status of tests on various iOS versions, including iOS 7 that we stopped
testing on a long time ago.
@mgol mgol requested a review from timmywil January 2, 2025 22:20
@mgol mgol self-assigned this Jan 2, 2025
mgol added a commit to mgol/jquery.com that referenced this pull request Jan 2, 2025
mgol added a commit to mgol/jquery-migrate that referenced this pull request Jan 4, 2025
As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and
failing our tests. Remove it from the test matrix. Also, add comments explaining
the status of tests on various iOS versions, including iOS 7 that we stopped
testing on a long time ago.

Ref jquery/jquery#5606
@mgol mgol added the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Jan 14, 2025
mgol added a commit to mgol/jquery-migrate that referenced this pull request Jan 14, 2025
As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and
failing our tests. Remove it from the test matrix. Also, add comments explaining
the status of tests on various iOS versions, including iOS 7 that we stopped
testing on a long time ago.

Ref jquery/jquery#5606
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as iOS 10 is not working anyway.

@timmywil timmywil merged commit 4705858 into jquery:3.x-stable Jan 14, 2025
17 checks passed
@timmywil timmywil added Tests and removed Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Build labels Jan 14, 2025
@mgol mgol added this to the 3.7.2 milestone Jan 14, 2025
@mgol mgol deleted the 3.x-ios10-emulator branch January 14, 2025 16:39
@mgol
Copy link
Member Author

mgol commented Jan 14, 2025

@timmywil can you also review a related docs change? jquery/jquery.com#248

mgol added a commit to jquery/jquery.com that referenced this pull request Jan 14, 2025
mgol added a commit to mgol/jquery-migrate that referenced this pull request Feb 2, 2025
As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
https://www.browserstack.com/device-tiers
That leads to devices with this iOS version often not being available and
failing our tests. Remove it from the test matrix. Also, add comments explaining
the status of tests on various iOS versions, including iOS 7 that we stopped
testing on a long time ago.

Ref jquery/jquery#5606
mgol added a commit to jquery/jquery-migrate that referenced this pull request Feb 18, 2025
Changes:

* Core: Remove support for jQuery 4.x

* Core: Don't reimplement deprecated but not removed APIs

    This will save space and avoid potential divergence from Core.

    To minimize risk, this only handles APIs still present in jQuery 4.x.

* Attributes: Update warnings.md to not mention jQuery 4.0

* Build: Rename more `main`s to `3.x-stable`s

* Event: Reimplement APIs deprecated in jQuery 3.0/3.1

    This fixes tests with 3.0/3.1 slim builds.

* Tests: Test on jQuery 3.1.1.slim in non-BrowserStack browser tests

    jQuery <3.2.0 doesn't include the deprecated module in the slim build so it
makes sense to test on one of these versions in slim mode even on PRs.

* Build: Stop testing on iOS 10

    As of January 2025, iOS 10 is a tier 4 device on BrowserStack:
    https://www.browserstack.com/device-tiers
    That leads to devices with this iOS version often not being available and
    failing our tests. Remove it from the test matrix. Also, add comments explaining
    the status of tests on various iOS versions, including iOS 7 that we stopped
    testing on a long time ago.

* Build: Update a vulnerable dependency

* Core: Update the package.json description

    Indicate this version of Migrate helps with updating jQuery to 3.x, not 3.0+.

* Docs: Link to jQuery Browser Support page in README.md

Closes gh-554
Ref gh-555
Ref jquery/jquery#5606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants