-
Notifications
You must be signed in to change notification settings - Fork 20.6k
Tests: migrate test runner to jquery-test-runner #5604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- this might fix an error on Windows pertaining to esm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise looks good but where is the runner code? https://www.npmjs.com/package/jquery-test-runner points to https://github.com/jquery/jquery-test-runner which is a 404 to me. I should be seeing all the repos in the org with my permissions.
|
@timmywil Can you move the repo and add me ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock you but please remember about adding the owners to the runner package!
Summary
I've moved all the code from
test/runner
into a package called jquery-test-runner. The changes to this repo are fairly simple. It uses the binary included in that package to run tests in browsers using selenium and browserstack.Some things to note:
jtr
(alias forjquery-test-runner
) binary includes several commands. The default command is for test runs (jtr
orjtr run
). jtr also includesjtr serve
, which has a-p
(--port
) option (rather than an env var). Seenpx jtr --help
for all commands and options.jquery-test-runner
.test/runner
folder, which means the recent changes to allow Edge runs in IE-mode have been kept,express
is not used for the test server, etc. jquery-migrate and jquery-ui will now be able to take advantage of those changes.jquery-test-runner
can take a YAML config file, with support for all of the same options as the command line. I considered JSON and JS, but I liked how terse the YAML was. See jtr-isolate.yml for an example, which is used to create a separate run for each module in BrowserStack runs while still sharing browser instances.Once we merge this to
jquery
, I'll make PRs forjquery-migrate
andjquery-ui
.At some point, we can move jquery-test-runner over to the jquery org.movedChecklist