Build: Fix pre release matching in compare size regex #5584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
commented
Nov 20, 2024
| // The short SHA so commits can be compared against each other | ||
| // and .dirty to compare with the existing branch during development. | ||
| const sha = /jQuery v\d+.\d+.\d+(?:-\w+)?(?:\+slim\.|\+)?([^ \.]+(?:\.dirty)?)?/.exec( contents )[ 1 ]; | ||
| const sha = /jQuery v\d+.\d+.\d+(?:-[\w\.]+)?(?:\+slim\.|\+)?(\w+(?:\.dirty)?)?/.exec( contents )[ 1 ]; |
Member
Author
There was a problem hiding this comment.
On the second change, I realized the matching didn't have to be so broad. SHAs are just letters and numbers.
mgol
approved these changes
Nov 20, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
I tested this locally, looks good!
mgol
changed the title
mgol
pushed a commit
to mgol/jquery
that referenced
this pull request
Nov 21, 2024
Closes jquerygh-5584 (cherry picked from commit 041f6e3)
Member
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@mgol noticed this in #5583 (comment)
.2inbeta.2.Checklist