Selector: Properly deprecate jQuery.expr[ ":" ]/jQuery.expr.filters
#5580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those APIs have formally been deprecated since `3.0.0`, but they never made its way into the deprecated module. `jQuery.expr[ ":" ]` has been removed when Sizzle got inlined into Core in jquerygh-4395; this change restores it. Ref jquerygh-5570 Ref jquerygh-4395
2 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 4, 2024
Those APIs have formally been deprecated since `3.0.0`, but they never made its way into the deprecated module. Ref jquerygh-5580
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Nov 4, 2024
Those APIs have formally been deprecated since `3.0.0`, but they never made its way into the deprecated module. Ref jquerygh-5580
timmywil
approved these changes
Nov 4, 2024
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
LGTM. I'm just glad we got it restored before the RC.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Those APIs have formally been deprecated since
3.0.0, but they never made its way into the deprecated module.jQuery.expr[ ":" ]has been removed when Sizzle got inlined into Core in gh-4395; this change restores it.Ref gh-5570
Ref gh-4395
PR for
3.x-stable: #5570Checklist