Tests: Add custom attribute getter tests to the selector module#5568
Merged
mgol merged 1 commit intojquery:mainfrom Dec 16, 2024
Merged
Tests: Add custom attribute getter tests to the selector module#5568mgol merged 1 commit intojquery:mainfrom
mgol merged 1 commit intojquery:mainfrom
Conversation
Sizzle & the `3.x-stable` branch have tests adding a custom attribute getter to `attrHandle` and checking if selection takes it into account. `attrHandle` was removed from the `4.x` line so the tests were not ported to the `main` branch, but the `4.x` line takes standard jQuery attribute getters into account instead and we should test for that. Backport the `3.x-stable` selector tests for custom attribute getters, changing `jQuery.expr.attrHandle` to `jQuery.attrHooks`.
timmywil
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sizzle & the
3.x-stablebranch have tests adding a custom attribute getter toattrHandleand checking if selection takes it into account.attrHandlewas removed from the4.xline so the tests were not ported to themainbranch, but the4.xline takes standard jQuery attribute getters into account instead and we should test for that.Backport the
3.x-stableselector tests for custom attribute getters, changingjQuery.expr.attrHandletojQuery.attrHooks.Checklist
If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com