Skip to content

Tests: replace express with basic Node server#5527

Merged
timmywil merged 3 commits intojquery:mainfrom
timmywil:drop-express
Aug 9, 2024
Merged

Tests: replace express with basic Node server#5527
timmywil merged 3 commits intojquery:mainfrom
timmywil:drop-express

Conversation

@timmywil
Copy link
Member

Summary

  • Removed express, body-parser, and express-body-parser-error-handler
  • The new server has support for basic connect-style middleware. No changes were required in existing middleware.
  • The server logs responses when run via npm run test:server. Output for CLI test commands (npm run test:unit) is left unchanged.

Checklist

@timmywil timmywil added the Tests label Jul 30, 2024
@timmywil timmywil added this to the 4.0.0 milestone Jul 30, 2024
@timmywil timmywil requested a review from mgol July 30, 2024 18:48
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments but nothing major. Good to see this size decrease!

@timmywil timmywil merged commit c85454a into jquery:main Aug 9, 2024
@timmywil timmywil deleted the drop-express branch August 9, 2024 02:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Development

Successfully merging this pull request may close these issues.

3 participants