Release: ensure builds have the proper version #5519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- order hooks in execution order
- update workflow actions
timmywil
commented
Jul 15, 2024
| path: path.basename( dirent.path ), | ||
| contents: await readFile( path.join( dirent.path, dirent.name ), "utf8" ) | ||
| path: path.basename( dirent.parentPath ), | ||
| contents: await readFile( path.join( dirent.parentPath, dirent.name ), "utf8" ) |
Member
Author
There was a problem hiding this comment.
This was just because path was recently marked deprecated.
mgol
approved these changes
Jul 15, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
It'd be a bit cleaner to have scripts (i.e. runnable files) separate from libraries (e.g. files exporting utilities). Not a huge concern, though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I attempted the release this morning and noticed a couple things after the initial steps.
VERSIONneeded to be set in the environment. Theversionis not available in script contexts at theinitstage. This adds a full build toafter:bumpwith the new version, which happens just before publishing to npm. I addedcross-envto do this so it works on Windows as well.npm testwasselector-native, so the main jquery.js file was not correct.Also:
Checklist