Build: upgrade dependencies; fix bundler tests on windows #5509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also account for newly unused parameters in the slim builds
timmywil
commented
Jun 12, 2024
| console.log( "Running Webpack" ); | ||
|
|
||
| const { default: config } = await import( configPath ); | ||
| const { default: config } = await import( "../webpack.config.cjs" ); |
Member
Author
There was a problem hiding this comment.
This allows the bundler tests to run on windows. A full path with c: cannot be passed to import. Using the relative path instead was the least complicated solution.
mgol
approved these changes
Jun 14, 2024
Member
Author
|
test jquery ignore rule generalized |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgraded all possible dependencies
Checklist