Skip to content

Tests: remove unnecessary scroll feature test #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2024
Merged

Tests: remove unnecessary scroll feature test #5507

merged 1 commit into from
Jun 10, 2024

Conversation

timmywil
Copy link
Member

@timmywil timmywil commented Jun 10, 2024 •
edited
Loading

Summary

  • some offset tests related to fixed positioning were not running in any browser. Rather than fixing the support test, I've removed it as it's no longer needed for the current browser list.

Checklist

Sample BrowserStack run: https://github.com/timmywil/jquery/actions/runs/9449771847

@timmywil
Tests: remove unnecessary scroll feature test
3e40030 
- it wasn't working properly anyway
@timmywil timmywil added this to the 4.0.0 milestone Jun 10, 2024
@timmywil timmywil requested a review from mgol June 10, 2024 14:10
@timmywil timmywil merged commit ea31e4d into jquery:main Jun 10, 2024
13 checks passed
@timmywil timmywil deleted the offset-scroll branch June 10, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol

Assignees
No one assigned
Labels
Blocker Tests
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@timmywil @mgol