Tests: share queue/browser handling for all worker types #5460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- one queue to rule them all: browserstack, selenium, and jsdom - retries and hard retries are now supported in selenium - selenium tests now re-use browsers in the same way as browserstack
timmywil
commented
Mar 28, 2024
mgol
reviewed
Mar 29, 2024
Member
mgol
left a comment
mgol
left a comment
There was a problem hiding this comment.
Nice work! I have a few questions/remarks.
This was referenced Apr 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This simplifies things in a way that will be easier to manage across projects. In fact, we can consider adding browserstack tests to UI and it wouldn't change much. Granted, we still may not want to do that because it adds the burden of support for each browser tested.
Sample test run to make sure nothing broke: https://github.com/timmywil/jquery/actions/runs/8468961534/job/23203167696
Will make a 3.x PR when this one gets through review.
Checklist